Cleaner fix part 1

[bluesky.git] / bluesky / util.c

diff --git a/bluesky/util.c b/bluesky/util.c
index 45bc9f5..3652d1a 100644 (file)
--- a/bluesky/util.c
+++ b/bluesky/util.c
@@ -83,6 +83,7 @@ BlueSkyRCStr *bluesky_string_new_from_mmap(BlueSkyCacheFile *mmap,
                                            int offset, gsize len)
 {
     g_assert(offset + len <= mmap->len);
+    g_assert(mmap->addr != NULL);
 
     BlueSkyRCStr *string = g_new(BlueSkyRCStr, 1);
     string->mmap = mmap;
@@ -349,21 +350,32 @@ typedef struct {
     char *message;
 } RTEvent;
 
+/* To catch attempts to access to invalid profile structures. */
+#define PROFILE_MAGIC 0x439929d8
+
+static FILE *profiling_file = NULL;
+
 BlueSkyProfile *bluesky_profile_new()
 {
     BlueSkyProfile *profile = g_new0(BlueSkyProfile, 1);
     profile->lock = g_mutex_new();
+    profile->magic = PROFILE_MAGIC;
     return profile;
 }
 
 void bluesky_profile_free(BlueSkyProfile *profile)
 {
+    if (profile->magic != PROFILE_MAGIC) {
+        g_warning("Access to invalid BlueSkyProfile object!");
+        return;
+    }
     while (profile->events != NULL) {
         RTEvent *event = (RTEvent *)profile->events->data;
         g_free(event->message);
         g_free(event);
         profile->events = g_list_delete_link(profile->events, profile->events);
     }
+    profile->magic = 0;
     g_mutex_free(profile->lock);
     g_free(profile->description);
     g_free(profile);
@@ -371,8 +383,15 @@ void bluesky_profile_free(BlueSkyProfile *profile)
 
 void bluesky_profile_add_event(BlueSkyProfile *profile, char *message)
 {
+    if (profiling_file == NULL)
+        return;
+
     g_return_if_fail(profile != NULL);
 
+    if (profile->magic != PROFILE_MAGIC) {
+        g_warning("Access to invalid BlueSkyProfile object!");
+        return;
+    }
     g_mutex_lock(profile->lock);
     RTEvent *event = g_new(RTEvent, 1);
     event->timestamp = bluesky_now_hires();
@@ -383,7 +402,6 @@ void bluesky_profile_add_event(BlueSkyProfile *profile, char *message)
     g_mutex_unlock(profile->lock);
 }
 
-static FILE *profiling_file = NULL;
 static GStaticMutex profiling_print_lock = G_STATIC_MUTEX_INIT;
 
 void bluesky_profile_set_output(FILE *stream)
@@ -393,9 +411,17 @@ void bluesky_profile_set_output(FILE *stream)
 
 void bluesky_profile_print(BlueSkyProfile *profile)
 {
-    FILE *stream = profiling_file ? profiling_file : stdout;
+    FILE *stream = profiling_file;
+    if (stream == NULL)
+        return;
+
     g_return_if_fail(profile != NULL);
 
+    if (profile->magic != PROFILE_MAGIC) {
+        g_warning("Access to invalid BlueSkyProfile object!");
+        return;
+    }
+
     g_mutex_lock(profile->lock);
     g_static_mutex_lock(&profiling_print_lock);
     fprintf(stream, "Event Timeline: %s\n", profile->description);