GMutex *lock;
GCond *cond_idle;
int pending; /* Count of operations not yet complete. */
+
+ struct bluesky_stats *stats_get, *stats_put;
};
GHashTable *store_implementations;
+/* Thread pool for calling notifier functions when an operation completes.
+ * These are called in a separate thread for locking reasons: we want to call
+ * the notifiers without the lock on the async object held, but completion
+ * occurs when the lock is held--so we need some way to defer the call. This
+ * isn't really optimal from a cache-locality standpoint. */
+static GThreadPool *notifier_thread_pool;
+
void bluesky_store_register(const BlueSkyStoreImplementation *impl,
const gchar *name)
{
{
const BlueSkyStoreImplementation *impl;
- impl = g_hash_table_lookup(store_implementations, type);
- if (impl == NULL)
+ gchar *scheme, *path;
+ scheme = g_strdup(type);
+ path = strchr(scheme, ':');
+ if (path != NULL) {
+ *path = '\0';
+ path++;
+ }
+
+ impl = g_hash_table_lookup(store_implementations, scheme);
+ if (impl == NULL) {
+ g_free(scheme);
return NULL;
+ }
- gpointer handle = impl->create();
- if (handle == NULL)
+ gpointer handle = impl->create(path);
+ if (handle == NULL) {
+ g_free(scheme);
return NULL;
+ }
BlueSkyStore *store = g_new(BlueSkyStore, 1);
store->impl = impl;
store->lock = g_mutex_new();
store->cond_idle = g_cond_new();
store->pending = 0;
+ store->stats_get = bluesky_stats_new(g_strdup_printf("Store[%s]: GETS",
+ type));
+ store->stats_put = bluesky_stats_new(g_strdup_printf("Store[%s]: PUTS",
+ type));
+ g_free(scheme);
return store;
}
async->key = NULL;
async->data = NULL;
async->result = -1;
+ async->notifiers = NULL;
+ async->notifier_count = 0;
+ async->barrier = NULL;
async->store_private = NULL;
return async;
}
+gpointer bluesky_store_async_get_handle(BlueSkyStoreAsync *async)
+{
+ return async->store->handle;
+}
+
void bluesky_store_async_ref(BlueSkyStoreAsync *async)
{
if (async == NULL)
return;
+ g_return_if_fail(g_atomic_int_get(&async->refcount) > 0);
+
g_atomic_int_inc(&async->refcount);
}
g_free(async->key);
bluesky_string_unref(async->data);
g_free(async);
- g_print("Freed async\n");
}
}
return;
}
- while (async->status != ASYNC_COMPLETE) {
+ while (async->status != ASYNC_COMPLETE
+ || g_atomic_int_get(&async->notifier_count) > 0) {
g_cond_wait(async->completion_cond, async->lock);
}
g_mutex_unlock(async->lock);
}
+/* Add a notifier function to be called when the operation completes. */
+void bluesky_store_async_add_notifier(BlueSkyStoreAsync *async,
+ GFunc func, gpointer user_data)
+{
+ struct BlueSkyNotifierList *nl = g_new(struct BlueSkyNotifierList, 1);
+ g_mutex_lock(async->lock);
+ nl->next = async->notifiers;
+ nl->func = func;
+ nl->async = async; bluesky_store_async_ref(async);
+ nl->user_data = user_data;
+ g_atomic_int_inc(&async->notifier_count);
+ if (async->status == ASYNC_COMPLETE) {
+ g_thread_pool_push(notifier_thread_pool, nl, NULL);
+ } else {
+ async->notifiers = nl;
+ }
+ g_mutex_unlock(async->lock);
+}
+
+static void op_complete(gpointer a, gpointer b)
+{
+ BlueSkyStoreAsync *barrier = (BlueSkyStoreAsync *)b;
+
+ bluesky_store_async_ref(barrier);
+ g_mutex_lock(barrier->lock);
+ barrier->store_private
+ = GINT_TO_POINTER(GPOINTER_TO_INT(barrier->store_private) - 1);
+ if (GPOINTER_TO_INT(barrier->store_private) == 0
+ && barrier->status != ASYNC_NEW) {
+ bluesky_store_async_mark_complete(barrier);
+ }
+ g_mutex_unlock(barrier->lock);
+ bluesky_store_async_unref(barrier);
+}
+
/* Mark an asynchronous operation as complete. This should only be called by
- * the store implementations. The lock must be held when calling this
- * function. */
+ * the store implementations. The lock should be held when calling this
+ * function. Any notifier functions will be called, but in a separate thread
+ * and without the lock held. */
void bluesky_store_async_mark_complete(BlueSkyStoreAsync *async)
{
- if (async->status != ASYNC_COMPLETE) {
+ g_return_if_fail(async->status != ASYNC_COMPLETE);
+
+ bluesky_time_hires elapsed = bluesky_now_hires() - async->start_time;
+ bluesky_time_hires latency = bluesky_now_hires() - async->exec_time;
+
+ if (async->op != STORE_OP_BARRIER) {
g_mutex_lock(async->store->lock);
async->store->pending--;
if (async->store->pending == 0)
async->status = ASYNC_COMPLETE;
g_cond_broadcast(async->completion_cond);
+
+ if (async->barrier != NULL && async->notifiers == NULL)
+ op_complete(async, async->barrier);
+
+ while (async->notifiers != NULL) {
+ struct BlueSkyNotifierList *nl = async->notifiers;
+ async->notifiers = nl->next;
+ g_thread_pool_push(notifier_thread_pool, nl, NULL);
+ }
+
+ if (bluesky_verbose) {
+ g_log("bluesky/store", G_LOG_LEVEL_DEBUG,
+ "[%p] complete: elapsed = %"PRIi64" ns, latency = %"PRIi64" ns",
+ async, elapsed, latency);
+ }
+
+ if (async->data) {
+ if (async->op == STORE_OP_GET) {
+ bluesky_stats_add(async->store->stats_get, async->data->len);
+ } else if (async->op == STORE_OP_PUT) {
+ bluesky_stats_add(async->store->stats_put, async->data->len);
+ }
+ }
}
void bluesky_store_async_submit(BlueSkyStoreAsync *async)
{
BlueSkyStore *store = async->store;
+ async->start_time = bluesky_now_hires();
+
+ // Backends should fill this in with a better estimate of the actual time
+ // processing was started, if there could be a delay from submission time.
+ async->exec_time = bluesky_now_hires();
+
+ if (bluesky_verbose) {
+ g_log("bluesky/store", G_LOG_LEVEL_DEBUG, "[%p] submit: %s %s",
+ async,
+ async->op == STORE_OP_GET ? "GET"
+ : async->op == STORE_OP_PUT ? "PUT"
+ : async->op == STORE_OP_DELETE ? "DELETE"
+ : async->op == STORE_OP_BARRIER ? "BARRIER" : "???",
+ async->key);
+ }
+
+ /* Barriers are handled specially, and not handed down the storage
+ * implementation layer. */
+ if (async->op == STORE_OP_BARRIER) {
+ async->status = ASYNC_RUNNING;
+ if (GPOINTER_TO_INT(async->store_private) == 0)
+ bluesky_store_async_mark_complete(async);
+ return;
+ }
+
g_mutex_lock(async->store->lock);
async->store->pending++;
g_mutex_unlock(async->store->lock);
bluesky_store_async_wait(async);
}
+/* Add the given operation to the barrier. The barrier will not complete until
+ * all operations added to it have completed. */
+void bluesky_store_add_barrier(BlueSkyStoreAsync *barrier,
+ BlueSkyStoreAsync *async)
+{
+ g_return_if_fail(barrier->op == STORE_OP_BARRIER);
+
+ g_mutex_lock(barrier->lock);
+ barrier->store_private
+ = GINT_TO_POINTER(GPOINTER_TO_INT(barrier->store_private) + 1);
+ g_mutex_unlock(barrier->lock);
+
+ g_mutex_lock(async->lock);
+ if (async->barrier == NULL) {
+ async->barrier = barrier;
+ } else {
+ g_warning("Adding async to more than one barrier!\n");
+ bluesky_store_async_add_notifier(async, op_complete, barrier);
+ }
+ g_mutex_unlock(async->lock);
+}
+
+static void notifier_task(gpointer n, gpointer s)
+{
+ struct BlueSkyNotifierList *notifier = (struct BlueSkyNotifierList *)n;
+
+ notifier->func(notifier->async, notifier->user_data);
+ if (g_atomic_int_dec_and_test(¬ifier->async->notifier_count)) {
+ g_mutex_lock(notifier->async->lock);
+ if (notifier->async->barrier != NULL)
+ op_complete(notifier->async, notifier->async->barrier);
+ g_cond_broadcast(notifier->async->completion_cond);
+ g_mutex_unlock(notifier->async->lock);
+ }
+ bluesky_store_async_unref(notifier->async);
+ g_free(notifier);
+}
+
void bluesky_store_sync(BlueSkyStore *store)
{
g_mutex_lock(store->lock);
- g_print("Waiting for pending store operations to complete...\n");
+ if (bluesky_verbose) {
+ g_log("bluesky/store", G_LOG_LEVEL_DEBUG,
+ "Waiting for pending store operations to complete...");
+ }
while (store->pending > 0) {
g_cond_wait(store->cond_idle, store->lock);
}
g_mutex_unlock(store->lock);
- g_print("Operations are complete.\n");
+ if (bluesky_verbose) {
+ g_log("bluesky/store", G_LOG_LEVEL_DEBUG, "Operations are complete.");
+ }
}
/* Convenience wrappers that perform a single operation synchronously. */
bluesky_store_async_unref(async);
}
-#if 0
/* Simple in-memory data store for test purposes. */
typedef struct {
GMutex *lock;
GHashTable *store;
} MemStore;
-static gpointer memstore_create()
+static gpointer memstore_create(const gchar *path)
{
MemStore *store = g_new(MemStore, 1);
store->lock = g_mutex_new();
g_hash_table_insert(store->store, g_strdup(key), val);
}
+static void memstore_submit(gpointer s, BlueSkyStoreAsync *async)
+{
+ g_return_if_fail(async->status == ASYNC_NEW);
+ g_return_if_fail(async->op != STORE_OP_NONE);
+
+ switch (async->op) {
+ case STORE_OP_GET:
+ async->data = memstore_get(s, async->key);
+ break;
+
+ case STORE_OP_PUT:
+ memstore_put(s, async->key, async->data);
+ break;
+
+ default:
+ g_warning("Uknown operation type for MemStore: %d\n", async->op);
+ return;
+ }
+
+ bluesky_store_async_mark_complete(async);
+}
+
+static void memstore_cleanup(gpointer store, BlueSkyStoreAsync *async)
+{
+}
+
static BlueSkyStoreImplementation memstore_impl = {
.create = memstore_create,
.destroy = memstore_destroy,
- .get = memstore_get,
- .put = memstore_put,
+ .submit = memstore_submit,
+ .cleanup = memstore_cleanup,
};
/* Store implementation which writes data as files to disk. */
-static gpointer filestore_create()
+static gpointer filestore_create(const gchar *path)
{
return GINT_TO_POINTER(1);
}
{
}
-static BlueSkyRCStr *filestore_get(gpointer s, const gchar *key)
+static BlueSkyRCStr *filestore_get(const gchar *key)
{
gchar *contents = NULL;
gsize length;
return bluesky_string_new(contents, length);
}
-static void filestore_put(gpointer s, const gchar *key, BlueSkyRCStr *val)
+static void filestore_put(const gchar *key, BlueSkyRCStr *val)
{
g_file_set_contents(key, val->data, val->len, NULL);
}
+static void filestore_submit(gpointer s, BlueSkyStoreAsync *async)
+{
+ g_return_if_fail(async->status == ASYNC_NEW);
+ g_return_if_fail(async->op != STORE_OP_NONE);
+
+ switch (async->op) {
+ case STORE_OP_GET:
+ async->data = filestore_get(async->key);
+ async->result = 0;
+ break;
+
+ case STORE_OP_PUT:
+ filestore_put(async->key, async->data);
+ async->result = 0;
+ break;
+
+ default:
+ g_warning("Uknown operation type for FileStore: %d\n", async->op);
+ return;
+ }
+
+ bluesky_store_async_mark_complete(async);
+}
+
+static void filestore_cleanup(gpointer store, BlueSkyStoreAsync *async)
+{
+}
+
static BlueSkyStoreImplementation filestore_impl = {
.create = filestore_create,
.destroy = filestore_destroy,
- .get = filestore_get,
- .put = filestore_put,
+ .submit = filestore_submit,
+ .cleanup = filestore_cleanup,
};
-#endif
void bluesky_store_init()
{
store_implementations = g_hash_table_new(g_str_hash, g_str_equal);
- //bluesky_store_register(&memstore_impl, "mem");
- //bluesky_store_register(&filestore_impl, "file");
+ notifier_thread_pool = g_thread_pool_new(notifier_task, NULL,
+ bluesky_max_threads, FALSE, NULL);
+ bluesky_store_register(&memstore_impl, "mem");
+ bluesky_store_register(&filestore_impl, "file");
}
projects / bluesky.git / blobdiff