* (will) include Amazon S3 and a simple local store for testing purposes.
* Operations may be performed asynchronously. */
-struct _BlueSkyStore {
+struct BlueSkyStore {
const BlueSkyStoreImplementation *impl;
gpointer handle;
GMutex *lock;
GCond *cond_idle;
int pending; /* Count of operations not yet complete. */
+
+ struct bluesky_stats *stats_get, *stats_put;
};
GHashTable *store_implementations;
{
const BlueSkyStoreImplementation *impl;
- impl = g_hash_table_lookup(store_implementations, type);
- if (impl == NULL)
+ gchar *scheme, *path;
+ scheme = g_strdup(type);
+ path = strchr(scheme, ':');
+ if (path != NULL) {
+ *path = '\0';
+ path++;
+ }
+
+ impl = g_hash_table_lookup(store_implementations, scheme);
+ if (impl == NULL) {
+ g_free(scheme);
return NULL;
+ }
- gpointer handle = impl->create();
- if (handle == NULL)
+ gpointer handle = impl->create(path);
+ if (handle == NULL) {
+ g_free(scheme);
return NULL;
+ }
BlueSkyStore *store = g_new(BlueSkyStore, 1);
store->impl = impl;
store->lock = g_mutex_new();
store->cond_idle = g_cond_new();
store->pending = 0;
+ store->stats_get = bluesky_stats_new(g_strdup_printf("Store[%s]: GETS",
+ type));
+ store->stats_put = bluesky_stats_new(g_strdup_printf("Store[%s]: PUTS",
+ type));
+ g_free(scheme);
return store;
}
g_free(store);
}
+char *bluesky_store_lookup_last(BlueSkyStore *store, const char *prefix)
+{
+ return store->impl->lookup_last(store->handle, prefix);
+}
+
BlueSkyStoreAsync *bluesky_store_async_new(BlueSkyStore *store)
{
BlueSkyStoreAsync *async;
async->op = STORE_OP_NONE;
async->key = NULL;
async->data = NULL;
+ async->start = async->len = 0;
+ async->range_done = FALSE;
async->result = -1;
async->notifiers = NULL;
+ async->notifier_count = 0;
+ async->barrier = NULL;
async->store_private = NULL;
+ async->profile = NULL;
return async;
}
+gpointer bluesky_store_async_get_handle(BlueSkyStoreAsync *async)
+{
+ return async->store->handle;
+}
+
void bluesky_store_async_ref(BlueSkyStoreAsync *async)
{
if (async == NULL)
g_free(async->key);
bluesky_string_unref(async->data);
g_free(async);
- g_log("bluesky/store", G_LOG_LEVEL_DEBUG,
- "freeing async");
}
}
return;
}
- while (async->status != ASYNC_COMPLETE) {
+ while (async->status != ASYNC_COMPLETE
+ || g_atomic_int_get(&async->notifier_count) > 0) {
g_cond_wait(async->completion_cond, async->lock);
}
GFunc func, gpointer user_data)
{
struct BlueSkyNotifierList *nl = g_new(struct BlueSkyNotifierList, 1);
+ g_mutex_lock(async->lock);
nl->next = async->notifiers;
nl->func = func;
nl->async = async; bluesky_store_async_ref(async);
nl->user_data = user_data;
+ g_atomic_int_inc(&async->notifier_count);
if (async->status == ASYNC_COMPLETE) {
g_thread_pool_push(notifier_thread_pool, nl, NULL);
} else {
async->notifiers = nl;
}
+ g_mutex_unlock(async->lock);
+}
+
+static void op_complete(gpointer a, gpointer b)
+{
+ BlueSkyStoreAsync *barrier = (BlueSkyStoreAsync *)b;
+
+ bluesky_store_async_ref(barrier);
+ g_mutex_lock(barrier->lock);
+ barrier->store_private
+ = GINT_TO_POINTER(GPOINTER_TO_INT(barrier->store_private) - 1);
+ if (GPOINTER_TO_INT(barrier->store_private) == 0
+ && barrier->status != ASYNC_NEW) {
+ bluesky_store_async_mark_complete(barrier);
+ }
+ g_mutex_unlock(barrier->lock);
+ bluesky_store_async_unref(barrier);
}
/* Mark an asynchronous operation as complete. This should only be called by
{
g_return_if_fail(async->status != ASYNC_COMPLETE);
- g_mutex_lock(async->store->lock);
- async->store->pending--;
- if (async->store->pending == 0)
- g_cond_broadcast(async->store->cond_idle);
- g_mutex_unlock(async->store->lock);
+ bluesky_time_hires elapsed = bluesky_now_hires() - async->start_time;
+ bluesky_time_hires latency = bluesky_now_hires() - async->exec_time;
+
+ if (async->op != STORE_OP_BARRIER) {
+ g_mutex_lock(async->store->lock);
+ async->store->pending--;
+ if (async->store->pending == 0)
+ g_cond_broadcast(async->store->cond_idle);
+ g_mutex_unlock(async->store->lock);
+ }
+
+ /* If the request was a range request but the backend read the entire
+ * object, select out the appropriate bytes. */
+ if (async->op == STORE_OP_GET
+ && !async->range_done
+ && async->result == 0
+ && async->data != NULL) {
+ if (async->start != 0 || async->len != 0) {
+ /* If the caller requesteda read outside the object, return an
+ * error. */
+ if (async->start + async->len > async->data->len) {
+ g_warning("Range request outside object boundaries!\n");
+ async->result = -1;
+ } else {
+ if (async->len == 0)
+ async->len = async->data->len - async->start;
+ BlueSkyRCStr *newstr = bluesky_string_new(g_memdup(&async->data->data[async->start], async->len), async->len);
+ bluesky_string_unref(async->data);
+ async->data = newstr;
+ async->range_done = TRUE;
+ }
+ }
+ }
async->status = ASYNC_COMPLETE;
g_cond_broadcast(async->completion_cond);
+ if (async->barrier != NULL && async->notifiers == NULL)
+ op_complete(async, async->barrier);
+
while (async->notifiers != NULL) {
struct BlueSkyNotifierList *nl = async->notifiers;
async->notifiers = nl->next;
g_thread_pool_push(notifier_thread_pool, nl, NULL);
}
+
+ if (async->profile) {
+ bluesky_profile_add_event(
+ async->profile,
+ g_strdup_printf("%s for %s complete",
+ async->op == STORE_OP_GET ? "GET"
+ : async->op == STORE_OP_PUT ? "PUT"
+ : async->op == STORE_OP_DELETE ? "DELETE"
+ : async->op == STORE_OP_BARRIER ? "BARRIER" : "???",
+ async->key)
+ );
+ }
+
+ if (bluesky_verbose) {
+ g_log("bluesky/store", G_LOG_LEVEL_DEBUG,
+ "[%p] complete: elapsed = %"PRIi64" ns, latency = %"PRIi64" ns",
+ async, elapsed, latency);
+ }
+
+ if (async->data) {
+ if (async->op == STORE_OP_GET) {
+ bluesky_stats_add(async->store->stats_get, async->data->len);
+ } else if (async->op == STORE_OP_PUT) {
+ bluesky_stats_add(async->store->stats_put, async->data->len);
+ }
+ }
}
void bluesky_store_async_submit(BlueSkyStoreAsync *async)
{
BlueSkyStore *store = async->store;
+ async->start_time = bluesky_now_hires();
+
+ // Backends should fill this in with a better estimate of the actual time
+ // processing was started, if there could be a delay from submission time.
+ async->exec_time = bluesky_now_hires();
+
+ if (async->profile) {
+ bluesky_profile_add_event(
+ async->profile,
+ g_strdup_printf("Start %s for %s",
+ async->op == STORE_OP_GET ? "GET"
+ : async->op == STORE_OP_PUT ? "PUT"
+ : async->op == STORE_OP_DELETE ? "DELETE"
+ : async->op == STORE_OP_BARRIER ? "BARRIER" : "???",
+ async->key)
+ );
+ }
+
+ if (bluesky_verbose) {
+ g_log("bluesky/store", G_LOG_LEVEL_DEBUG, "[%p] submit: %s %s",
+ async,
+ async->op == STORE_OP_GET ? "GET"
+ : async->op == STORE_OP_PUT ? "PUT"
+ : async->op == STORE_OP_DELETE ? "DELETE"
+ : async->op == STORE_OP_BARRIER ? "BARRIER" : "???",
+ async->key);
+ }
+
/* Barriers are handled specially, and not handed down the storage
* implementation layer. */
if (async->op == STORE_OP_BARRIER) {
return;
}
- g_log("bluesky/store", G_LOG_LEVEL_DEBUG, "submit: %s %s",
- async->op == STORE_OP_GET ? "GET"
- : async->op == STORE_OP_PUT ? "PUT"
- : async->op == STORE_OP_DELETE ? "DELETE" : "???",
- async->key);
-
g_mutex_lock(async->store->lock);
async->store->pending++;
g_mutex_unlock(async->store->lock);
bluesky_store_async_wait(async);
}
-static void op_complete(gpointer a, gpointer b)
-{
- BlueSkyStoreAsync *barrier = (BlueSkyStoreAsync *)b;
-
- g_mutex_lock(barrier->lock);
- barrier->store_private
- = GINT_TO_POINTER(GPOINTER_TO_INT(barrier->store_private) - 1);
- if (GPOINTER_TO_INT(barrier->store_private) == 0
- && barrier->status != ASYNC_NEW) {
- bluesky_store_async_mark_complete(barrier);
- }
- g_mutex_unlock(barrier->lock);
-}
-
/* Add the given operation to the barrier. The barrier will not complete until
* all operations added to it have completed. */
void bluesky_store_add_barrier(BlueSkyStoreAsync *barrier,
BlueSkyStoreAsync *async)
{
g_return_if_fail(barrier->op == STORE_OP_BARRIER);
+
+ g_mutex_lock(barrier->lock);
barrier->store_private
= GINT_TO_POINTER(GPOINTER_TO_INT(barrier->store_private) + 1);
- bluesky_store_async_add_notifier(async, op_complete, barrier);
+ g_mutex_unlock(barrier->lock);
+
+ g_mutex_lock(async->lock);
+ if (async->barrier == NULL && async->status != ASYNC_COMPLETE) {
+ async->barrier = barrier;
+ g_mutex_unlock(async->lock);
+ } else {
+ if (async->barrier != NULL)
+ g_warning("Adding async to more than one barrier!\n");
+ g_mutex_unlock(async->lock);
+ bluesky_store_async_add_notifier(async, op_complete, barrier);
+ }
}
static void notifier_task(gpointer n, gpointer s)
struct BlueSkyNotifierList *notifier = (struct BlueSkyNotifierList *)n;
notifier->func(notifier->async, notifier->user_data);
+ if (g_atomic_int_dec_and_test(¬ifier->async->notifier_count)) {
+ g_mutex_lock(notifier->async->lock);
+ if (notifier->async->barrier != NULL)
+ op_complete(notifier->async, notifier->async->barrier);
+ g_cond_broadcast(notifier->async->completion_cond);
+ g_mutex_unlock(notifier->async->lock);
+ }
bluesky_store_async_unref(notifier->async);
g_free(notifier);
}
void bluesky_store_sync(BlueSkyStore *store)
{
g_mutex_lock(store->lock);
- g_print("Waiting for pending store operations to complete...\n");
+ if (bluesky_verbose) {
+ g_log("bluesky/store", G_LOG_LEVEL_DEBUG,
+ "Waiting for pending store operations to complete...");
+ }
while (store->pending > 0) {
g_cond_wait(store->cond_idle, store->lock);
}
g_mutex_unlock(store->lock);
- g_print("Operations are complete.\n");
+ if (bluesky_verbose) {
+ g_log("bluesky/store", G_LOG_LEVEL_DEBUG, "Operations are complete.");
+ }
}
/* Convenience wrappers that perform a single operation synchronously. */
GHashTable *store;
} MemStore;
-static gpointer memstore_create()
+static gpointer memstore_create(const gchar *path)
{
MemStore *store = g_new(MemStore, 1);
store->lock = g_mutex_new();
};
/* Store implementation which writes data as files to disk. */
-static gpointer filestore_create()
+static gpointer filestore_create(const gchar *path)
{
return GINT_TO_POINTER(1);
}
switch (async->op) {
case STORE_OP_GET:
async->data = filestore_get(async->key);
+ async->result = 0;
break;
case STORE_OP_PUT:
filestore_put(async->key, async->data);
+ async->result = 0;
break;
default:
{
}
+static char *filestore_lookup_last(gpointer store, const char *prefix)
+{
+ char *last = NULL;
+ GDir *dir = g_dir_open(".", 0, NULL);
+ if (dir == NULL) {
+ g_warning("Unable to open directory for listing");
+ return NULL;
+ }
+
+ const gchar *file;
+ while ((file = g_dir_read_name(dir)) != NULL) {
+ if (strncmp(file, prefix, strlen(prefix)) == 0) {
+ if (last == NULL || strcmp(file, last) > 0) {
+ g_free(last);
+ last = g_strdup(file);
+ }
+ }
+ }
+ g_dir_close(dir);
+
+ return last;
+}
+
static BlueSkyStoreImplementation filestore_impl = {
.create = filestore_create,
.destroy = filestore_destroy,
.submit = filestore_submit,
.cleanup = filestore_cleanup,
+ .lookup_last = filestore_lookup_last,
+};
+
+/* A store implementation which simply discards all data, for testing. */
+static gpointer nullstore_create(const gchar *path)
+{
+ return (gpointer)nullstore_create;
+}
+
+static void nullstore_destroy(gpointer store)
+{
+}
+
+static void nullstore_submit(gpointer s, BlueSkyStoreAsync *async)
+{
+ bluesky_store_async_mark_complete(async);
+}
+
+static void nullstore_cleanup(gpointer store, BlueSkyStoreAsync *async)
+{
+}
+
+static BlueSkyStoreImplementation nullstore_impl = {
+ .create = nullstore_create,
+ .destroy = nullstore_destroy,
+ .submit = nullstore_submit,
+ .cleanup = nullstore_cleanup,
};
void bluesky_store_init()
{
store_implementations = g_hash_table_new(g_str_hash, g_str_equal);
- notifier_thread_pool = g_thread_pool_new(notifier_task, NULL, -1, FALSE,
- NULL);
+ notifier_thread_pool = g_thread_pool_new(notifier_task, NULL,
+ bluesky_max_threads, FALSE, NULL);
bluesky_store_register(&memstore_impl, "mem");
bluesky_store_register(&filestore_impl, "file");
+ bluesky_store_register(&nullstore_impl, "null");
}