projects
/
bluesky.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
d249434
)
Optimize overwrites of the last block of a file
author
Michael Vrable
<mvrable@cs.ucsd.edu>
Fri, 11 Mar 2011 22:31:26 +0000
(14:31 -0800)
committer
Michael Vrable
<mvrable@cs.ucsd.edu>
Fri, 11 Mar 2011 22:31:26 +0000
(14:31 -0800)
bluesky/file.c
patch
|
blob
|
history
diff --git
a/bluesky/file.c
b/bluesky/file.c
index
72467f3
..
1936375
100644
(file)
--- a/
bluesky/file.c
+++ b/
bluesky/file.c
@@
-163,16
+163,17
@@
void bluesky_file_write(BlueSkyInode *inode, uint64_t offset,
if (len == 0)
return;
if (len == 0)
return;
- // TODO: Optimization: If we are entirely overwriting a block we don't need
- // to fetch it frm storage first. We don't yet handle the case where the
- // partial last block of a file is entirely overwritten.
while (len > 0) {
uint64_t block_num = offset / BLUESKY_BLOCK_SIZE;
gint block_offset = offset % BLUESKY_BLOCK_SIZE;
gint bytes = MIN(BLUESKY_BLOCK_SIZE - block_offset, len);
gboolean preserve = TRUE;
while (len > 0) {
uint64_t block_num = offset / BLUESKY_BLOCK_SIZE;
gint block_offset = offset % BLUESKY_BLOCK_SIZE;
gint bytes = MIN(BLUESKY_BLOCK_SIZE - block_offset, len);
gboolean preserve = TRUE;
- if (block_offset == 0 && bytes == BLUESKY_BLOCK_SIZE) {
+ gsize block_size = BLUESKY_BLOCK_SIZE;
+ if (block_num == inode->blocks->len - 1) {
+ block_size = inode->size - block_num * BLUESKY_BLOCK_SIZE;
+ }
+ if (block_offset == 0 && bytes == block_size) {
preserve = FALSE;
}
bluesky_block_touch(inode, block_num, preserve);
preserve = FALSE;
}
bluesky_block_touch(inode, block_num, preserve);