projects / cumulus.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 41bf14f) | patch
Fix a segfault-causing bug when converting a numeric group to a name fails.
authorMichael Vrable <mvrable@cs.ucsd.edu>
Sat, 8 Aug 2009 02:28:31 +0000 (19:28 -0700)
committerMichael Vrable <mvrable@turin.ucsd.edu>
Sat, 8 Aug 2009 02:28:31 +0000 (19:28 -0700)
commitf6d3d525bf2c0afa0190e767f6de575cdbd5bcfd
tree13e83ec74867f1f538adc5dec5297d9f57724827tree | snapshot
parent41bf14f1d09d9da4d6c4df6795d2cf7a48a39ba7commit | diff
Fix a segfault-causing bug when converting a numeric group to a name fails.

The original code had a copy-and-paste bug when converting a numeric group
id into a symbolic group name: rather than checking that getgrgid returned
a valid result, it checked the result of getpwuid.  If any files in the
backup snapshot belonged to a non-existent group, this resulted in a
segfault.

Problem found and patch provided by Chris Wilson <chris@aptivate.org>.
scandir.cc diff | blob | history
Cumulus: Efficient filesystem backup through a simple storage interface